circuit: Remove log_warn triggered by a proto violation

Fixes #40932

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/changes/ticket40932 b/changes/ticket40932
new file mode 100644 (file)
index 0000000..10e1b65
--- /dev/null
+++ b/changes/ticket40932
@@ -0,0 +1,3 @@
+  o Minor bugfix (circuit):
+    - Remove a log_warn being triggered by a protocol violation that already
+      emits a protocol warning log. Fixes bug 40932; bugfix on 0.4.8.1-alpha.

diff --git a/src/core/or/relay.c b/src/core/or/relay.c
index 8e6fddf18b3b5f7f214a9fb8b6b20d635422db9c..3670353ad305f49894c80f0ad3d5afbd081be76a 100644 (file)
--- a/src/core/or/relay.c
+++ b/src/core/or/relay.c
@@ -751,7 +751,6 @@ relay_send_command_from_edge_,(streamid_t stream_id, circuit_t *orig_circ,
                                        cpath_layer, stream_id, filename,
                                        lineno);
   if (ret < 0) {
-    log_warn(LD_BUG,"circuit_package_relay_cell failed. Closing.");
     circuit_mark_for_close(circ, END_CIRC_REASON_INTERNAL);
     return -1;
   } else if (ret == 0) {

diff --git a/src/feature/hs/hs_intropoint.c b/src/feature/hs/hs_intropoint.c
index 02b5b4866b6cb0599d5a44aaf37c99428589eb29..e799a4c7e44ed978a7fe578069165acde53cf322 100644 (file)
--- a/src/feature/hs/hs_intropoint.c
+++ b/src/feature/hs/hs_intropoint.c
@@ -710,7 +710,6 @@ handle_introduce1(or_circuit_t *client_circ, const uint8_t *request,
                                    RELAY_COMMAND_INTRODUCE2,
                                    (char *) request, request_len, NULL)) {
     relay_increment_intro1_action(INTRO1_CIRCUIT_DEAD);
-    log_warn(LD_PROTOCOL, "Unable to send INTRODUCE2 cell to the service.");
     /* Inform the client that we can't relay the cell. Use the unknown ID
      * status code since it means that we do not know the service. */
     status = TRUNNEL_HS_INTRO_ACK_STATUS_UNKNOWN_ID;