]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: mediatek: mt8183: Release reserved memory on cleanup
authorCássio Gabriel <cassiogabrielcontato@gmail.com>
Wed, 27 May 2026 13:41:48 +0000 (10:41 -0300)
committerMark Brown <broonie@kernel.org>
Tue, 2 Jun 2026 15:10:34 +0000 (16:10 +0100)
The MT8183 AFE probe can assign reserved memory with
of_reserved_mem_device_init(), but the assignment is never released on
driver removal or later probe failures.

Register a devm cleanup action so the reserved memory assignment is
released consistently, matching newer Mediatek AFE drivers.

Fixes: ec4a10ca4a68 ("ASoC: mediatek: use reserved memory or enable buffer pre-allocation")
Cc: stable@vger.kernel.org
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Link: https://patch.msgid.link/20260527-asoc-mt8183-probe-cleanup-v1-1-4f4f5593c8d1@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c

index a7fef772760a6c58fcbda2f8503f9b203bf4444c..49a69728fd723432f0b1894af255ac0604b67b12 100644 (file)
@@ -766,6 +766,11 @@ static const dai_register_cb dai_register_cbs[] = {
        mt8183_dai_memif_register,
 };
 
+static void mt8183_afe_release_reserved_mem(void *data)
+{
+       of_reserved_mem_device_release(data);
+}
+
 static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
 {
        struct mtk_base_afe *afe;
@@ -794,6 +799,12 @@ static int mt8183_afe_pcm_dev_probe(struct platform_device *pdev)
        if (ret) {
                dev_info(dev, "no reserved memory found, pre-allocating buffers instead\n");
                afe->preallocate_buffers = true;
+       } else {
+               ret = devm_add_action_or_reset(dev,
+                                              mt8183_afe_release_reserved_mem,
+                                              dev);
+               if (ret)
+                       return ret;
        }
 
        /* initial audio related clock */