]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: cfg80211: restrict LMR feedback check to TB and non-TB ranging
authorPeddolla Harshavardhan Reddy <peddolla.reddy@oss.qualcomm.com>
Mon, 20 Apr 2026 09:08:44 +0000 (14:38 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 5 May 2026 11:25:27 +0000 (13:25 +0200)
The lmr_feedback field is only applicable to TB and non-TB ranging.
Currently, pmsr_parse_ftm() enforces lmr_feedback for all RSTA
requests, incorrectly rejecting valid EDCA-based RSTA requests.

Fix this by limiting the lmr_feedback requirement to TB and non-TB
ranging only.

Fixes: 853800c746d3 ("wifi: nl80211/cfg80211: support operating as RSTA in PMSR FTM request")
Co-developed-by: Kavita Kavita <kavita.kavita@oss.qualcomm.com>
Signed-off-by: Kavita Kavita <kavita.kavita@oss.qualcomm.com>
Signed-off-by: Peddolla Harshavardhan Reddy <peddolla.reddy@oss.qualcomm.com>
Link: https://patch.msgid.link/20260420090856.2152905-2-peddolla.reddy@oss.qualcomm.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/pmsr.c

index 4c8ea0583f94034776b6d802a9fe5255549e4145..afc0e3f931ec99c55d1c8fa94871ddc025732283 100644 (file)
@@ -195,7 +195,9 @@ static int pmsr_parse_ftm(struct cfg80211_registered_device *rdev,
                return -EOPNOTSUPP;
        }
 
-       if (out->ftm.rsta && !out->ftm.lmr_feedback) {
+       if (out->ftm.rsta &&
+           (out->ftm.non_trigger_based || out->ftm.trigger_based) &&
+           !out->ftm.lmr_feedback) {
                NL_SET_ERR_MSG_ATTR(info->extack,
                                    tb[NL80211_PMSR_FTM_REQ_ATTR_RSTA],
                                    "FTM: RSTA set without LMR feedback");