]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: tegra: Fix argument order in tegra_pcie_phy_disable()
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Oct 2016 21:04:13 +0000 (16:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:45:19 +0000 (03:45 -0400)
commit 8dd99bca7bfa4b62753b556c45d26f45ec9da6e6 upstream.

The tegra_pcie_phy_disable() path called pads_writel() with arguments in
the wrong order.  Swap them to be the "value, offset" order expected by
pads_writel().

Fixes: 6fe7c187e026 ("PCI: tegra: Support per-lane PHYs")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pci/host/pci-tegra.c

index 6de0757b11e4641b2a79b05fd62d19083656419e..84d650d892e7eb4199094a8edea6fb24d508873e 100644 (file)
@@ -856,7 +856,7 @@ static int tegra_pcie_phy_disable(struct tegra_pcie *pcie)
        /* override IDDQ */
        value = pads_readl(pcie, PADS_CTL);
        value |= PADS_CTL_IDDQ_1L;
-       pads_writel(pcie, PADS_CTL, value);
+       pads_writel(pcie, value, PADS_CTL);
 
        /* reset PLL */
        value = pads_readl(pcie, soc->pads_pll_ctl);