mailbox: tegra-hsp: Define dimensioning masks in SoC data

Tegra264 has updated HSP_INT_DIMENSIONING register as follows:
	* nSI is now BIT17:BIT21.
	* nDB is now BIT12:BIT16.

Currently, we are using a static macro HSP_nINT_MASK to get the values
from HSP_INT_DIMENSIONING register. This results in wrong values for nSI
for HSP instances that supports 16 shared interrupts.

Define dimensioning masks in soc data and use them to parse nSI, nDB,
nAS, nSS & nSM values.

Fixes: 602dbbacc3ef ("mailbox: tegra: add support for Tegra264")
Cc: stable@vger.kernel.org
Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>

diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index c1981f091bd1bb9249afa256dc27eef07555f285..ed9a0bb2bcd844567bb7accbe7e4425ac3942d49 100644 (file)
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Copyright (c) 2016-2023, NVIDIA CORPORATION.  All rights reserved.
+ * Copyright (c) 2016-2025, NVIDIA CORPORATION.  All rights reserved.
  */
 
 #include <linux/delay.h>
@@ -28,12 +28,6 @@
 #define HSP_INT_FULL_MASK      0xff
 
 #define HSP_INT_DIMENSIONING   0x380
-#define HSP_nSM_SHIFT          0
-#define HSP_nSS_SHIFT          4
-#define HSP_nAS_SHIFT          8
-#define HSP_nDB_SHIFT          12
-#define HSP_nSI_SHIFT          16
-#define HSP_nINT_MASK          0xf
 
 #define HSP_DB_TRIGGER 0x0
 #define HSP_DB_ENABLE  0x4
@@ -97,6 +91,20 @@ struct tegra_hsp_soc {
        bool has_per_mb_ie;
        bool has_128_bit_mb;
        unsigned int reg_stride;
+
+       /* Shifts for dimensioning register. */
+       unsigned int si_shift;
+       unsigned int db_shift;
+       unsigned int as_shift;
+       unsigned int ss_shift;
+       unsigned int sm_shift;
+
+       /* Masks for dimensioning register. */
+       unsigned int si_mask;
+       unsigned int db_mask;
+       unsigned int as_mask;
+       unsigned int ss_mask;
+       unsigned int sm_mask;
 };
 
 struct tegra_hsp {
@@ -747,11 +755,11 @@ static int tegra_hsp_probe(struct platform_device *pdev)
                return PTR_ERR(hsp->regs);
 
        value = tegra_hsp_readl(hsp, HSP_INT_DIMENSIONING);
-       hsp->num_sm = (value >> HSP_nSM_SHIFT) & HSP_nINT_MASK;
-       hsp->num_ss = (value >> HSP_nSS_SHIFT) & HSP_nINT_MASK;
-       hsp->num_as = (value >> HSP_nAS_SHIFT) & HSP_nINT_MASK;
-       hsp->num_db = (value >> HSP_nDB_SHIFT) & HSP_nINT_MASK;
-       hsp->num_si = (value >> HSP_nSI_SHIFT) & HSP_nINT_MASK;
+       hsp->num_sm = (value >> hsp->soc->sm_shift) & hsp->soc->sm_mask;
+       hsp->num_ss = (value >> hsp->soc->ss_shift) & hsp->soc->ss_mask;
+       hsp->num_as = (value >> hsp->soc->as_shift) & hsp->soc->as_mask;
+       hsp->num_db = (value >> hsp->soc->db_shift) & hsp->soc->db_mask;
+       hsp->num_si = (value >> hsp->soc->si_shift) & hsp->soc->si_mask;
 
        err = platform_get_irq_byname_optional(pdev, "doorbell");
        if (err >= 0)
@@ -915,6 +923,16 @@ static const struct tegra_hsp_soc tegra186_hsp_soc = {
        .has_per_mb_ie = false,
        .has_128_bit_mb = false,
        .reg_stride = 0x100,
+       .si_shift = 16,
+       .db_shift = 12,
+       .as_shift = 8,
+       .ss_shift = 4,
+       .sm_shift = 0,
+       .si_mask = 0xf,
+       .db_mask = 0xf,
+       .as_mask = 0xf,
+       .ss_mask = 0xf,
+       .sm_mask = 0xf,
 };
 
 static const struct tegra_hsp_soc tegra194_hsp_soc = {
@@ -922,6 +940,16 @@ static const struct tegra_hsp_soc tegra194_hsp_soc = {
        .has_per_mb_ie = true,
        .has_128_bit_mb = false,
        .reg_stride = 0x100,
+       .si_shift = 16,
+       .db_shift = 12,
+       .as_shift = 8,
+       .ss_shift = 4,
+       .sm_shift = 0,
+       .si_mask = 0xf,
+       .db_mask = 0xf,
+       .as_mask = 0xf,
+       .ss_mask = 0xf,
+       .sm_mask = 0xf,
 };
 
 static const struct tegra_hsp_soc tegra234_hsp_soc = {
@@ -929,6 +957,16 @@ static const struct tegra_hsp_soc tegra234_hsp_soc = {
        .has_per_mb_ie = false,
        .has_128_bit_mb = true,
        .reg_stride = 0x100,
+       .si_shift = 16,
+       .db_shift = 12,
+       .as_shift = 8,
+       .ss_shift = 4,
+       .sm_shift = 0,
+       .si_mask = 0xf,
+       .db_mask = 0xf,
+       .as_mask = 0xf,
+       .ss_mask = 0xf,
+       .sm_mask = 0xf,
 };
 
 static const struct tegra_hsp_soc tegra264_hsp_soc = {
@@ -936,6 +974,16 @@ static const struct tegra_hsp_soc tegra264_hsp_soc = {
        .has_per_mb_ie = false,
        .has_128_bit_mb = true,
        .reg_stride = 0x1000,
+       .si_shift = 17,
+       .db_shift = 12,
+       .as_shift = 8,
+       .ss_shift = 4,
+       .sm_shift = 0,
+       .si_mask = 0x1f,
+       .db_mask = 0x1f,
+       .as_mask = 0xf,
+       .ss_mask = 0xf,
+       .sm_mask = 0xf,
 };
 
 static const struct of_device_id tegra_hsp_match[] = {