]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: hisilicon: hikey960: Drop "snps,gctl-reset-quirk" and "snps,tx_de_emphasi...
authorRob Herring (Arm) <robh@kernel.org>
Mon, 5 Jan 2026 17:40:02 +0000 (11:40 -0600)
committerArnd Bergmann <arnd@arndb.de>
Wed, 7 Jan 2026 16:55:19 +0000 (17:55 +0100)
"snps,tx_de_emphasis" is supposed to be a u8, not a u32. Since it is big
endian, 0 will be read rather than 1. The DWC3 Linux driver simply ORs
the value if "snps,tx_de_emphasis_quirk" is set, so the 2 properties
have no effect. (The driver doesn't clear the field either which is
another problem).

"snps,gctl-reset-quirk" is not documented nor used in the driver, so
drop it as well.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20260105174002.2997615-1-robh@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts

index 3f13a960f34efd4b22769a0d9e29b5da76f5453c..ed84ab92fb19cbd1e58c3cefaf17d3d8b3f69064 100644 (file)
        snps,lfps_filter_quirk;
        snps,dis_u2_susphy_quirk;
        snps,dis_u3_susphy_quirk;
-       snps,tx_de_emphasis_quirk;
-       snps,tx_de_emphasis = <1>;
        snps,dis_enblslpm_quirk;
-       snps,gctl-reset-quirk;
        usb-role-switch;
        role-switch-default-mode = "host";
        port {