libcgroup Test: libcgroup-create-function-for-init-api

This patch creates a function test_cgroup_init() to test the libcgroup api
cgroup_init() under different scenario. In the earlier approach we were not
usong functions and were testing the api sequentialy under different conditions.
The new approach has a single function for 1 api which can handle the testing
under all conditions. The advantage is that the code repetition has reduced now.

Signed-off-by:	 Sudhir Kumar	 <skumar@linux.vnet.ibm.com>

git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/trunk@267 4f4bb910-9a46-0410-90c8-c897d4f1cd53

diff --git a/tests/libcgrouptest.h b/tests/libcgrouptest.h
index 70f565c6ce8745f8e0478b29cbf7112f12182995..79b065ae3ac99dfa8977539d6b07f44d3002f6f1 100644 (file)
--- a/tests/libcgrouptest.h
+++ b/tests/libcgrouptest.h
@@ -73,6 +73,10 @@ static int i;
 /* No extra message unless specified */
 char extra[SIZE] = "\n";
 
+/* Functions to test each API */
+void test_cgroup_init(int retcode, int i);
+/* API test functions end here */
+
 void get_controllers(char *name, int *exist);
 static int group_exist(char *path_group);
 static int set_controller(int controller, char *controller_name,

diff --git a/tests/libcgrouptest01.c b/tests/libcgrouptest01.c
index efe423acd15b1c4743006676605de9771c782a4f..f69d0223097bac42df3fcab25287610ef3349cbe 100644 (file)
--- a/tests/libcgrouptest01.c
+++ b/tests/libcgrouptest01.c
@@ -95,11 +95,7 @@ int main(int argc, char *argv[])
                 * Exp outcome: error ECGROUPNOTMOUNTED
                 */
 
-               retval = cgroup_init();
-               if (retval == ECGROUPNOTMOUNTED)
-                       message(++i, PASS, "init()\t", retval, extra);
-               else
-                       message(++i, FAIL, "init()",  retval, extra);
+               test_cgroup_init(ECGROUPNOTMOUNTED, 1);
 
                /*
                 * Test02: call cgroup_attach_task() with null group
@@ -209,11 +205,7 @@ int main(int argc, char *argv[])
                 * Exp outcome:  no error. return value 0
                 */
 
-               retval = cgroup_init();
-               if (retval == 0)
-                       message(++i, PASS, "init()\t", retval, extra);
-               else
-                       message(++i, FAIL, "init()\t",  retval, extra);
+               test_cgroup_init(0, 2);
 
                /*
                 * Test03: Call cgroup_attach_task() with null group and check
@@ -512,11 +504,7 @@ int main(int argc, char *argv[])
                 * Exp outcome: no error. 0 return value
                 */
 
-               retval = cgroup_init();
-               if (retval == 0)
-                       message(++i, PASS, "init()\t", retval, extra);
-               else
-                       message(++i, FAIL, "init()\t",  retval, extra);
+               test_cgroup_init(0, 1);
 
                /*
                 * Test02: Call cgroup_attach_task() with null group and check
@@ -1063,6 +1051,19 @@ int main(int argc, char *argv[])
        return 0;
 }
 
+
+void test_cgroup_init(int retcode, int i)
+{
+       int retval;
+       char extra[SIZE] = "\n";
+
+       retval = cgroup_init();
+       if (retval == retcode)
+               message(i, PASS, "init()\t", retval, extra);
+       else
+               message(i, FAIL, "init()",  retval, extra);
+}
+
 void get_controllers(char *name, int *exist)
 {
        int hierarchy, num_cgroups, enabled;