Fix memory leak in Surrogate-Capability header detection

 Detected by Coverity Scan. Issue 1318023

diff --git a/src/esi/Esi.cc b/src/esi/Esi.cc
index 106877d25760482d44f59720e32938e6f4c6abb2..9cd4ca78b82c87dcb36961d3b9ab193f871458a2 100644 (file)
--- a/src/esi/Esi.cc
+++ b/src/esi/Esi.cc
@@ -2283,14 +2283,12 @@ esiEnableProcessing (HttpReply *rep)
         HttpHdrScTarget *sctusable =
             rep->surrogate_control->getMergedTarget(Config.Accel.surrogate_id);
 
-        if (!sctusable || !sctusable->hasContent())
-            /* Nothing generic or targeted at us, or no
-             * content processing requested
-             */
-            return 0;
-
-        if (sctusable->content().pos("ESI/1.0") != NULL)
+        // found something targeted at us
+        if (sctusable &&
+                sctusable->hasContent() &&
+                sctusable->content().pos("ESI/1.0")) {
             rv = 1;
+        }
 
         delete sctusable;
     }