]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests/nolibc: use mutable buffer for execve() argv string
authorThomas Weißschuh <linux@weissschuh.net>
Mon, 25 May 2026 08:27:16 +0000 (10:27 +0200)
committerThomas Weißschuh <linux@weissschuh.net>
Tue, 26 May 2026 19:06:18 +0000 (21:06 +0200)
The existing code would trigger a warning under -Wwrite-strings which is
about to be enabled. Use a mutable buffer instead. While in this
specific case, casting away the 'const' would be fine, let's avoid casts
which are not really necessary.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Willy Tarreau <w@1wt.eu>
Link: https://patch.msgid.link/20260525-nolibc-write-strings-v2-2-ab5cc16c7b23@weissschuh.net
tools/testing/selftests/nolibc/nolibc-test.c

index 7c3b711c125c6ced6e5b398b77b35506b69bc4c7..c1c1ce43a047351b08ac7acaece9424fd9512cd5 100644 (file)
@@ -1584,7 +1584,7 @@ int run_syscall(int min, int max)
                CASE_TEST(dup2_m1);           tmp = dup2(-1, 100); EXPECT_SYSER(1, tmp, -1, EBADF); if (tmp != -1) close(tmp); break;
                CASE_TEST(dup3_0);            tmp = dup3(0, 100, 0);  EXPECT_SYSNE(1, tmp, -1); close(tmp); break;
                CASE_TEST(dup3_m1);           tmp = dup3(-1, 100, 0); EXPECT_SYSER(1, tmp, -1, EBADF); if (tmp != -1) close(tmp); break;
-               CASE_TEST(execve_root);       EXPECT_SYSER(1, execve("/", (char*[]){ [0] = "/", [1] = NULL }, NULL), -1, EACCES); break;
+               CASE_TEST(execve_root);       EXPECT_SYSER(1, execve("/", (char*[]){ [0] = (char []){"/"}, [1] = NULL }, NULL), -1, EACCES); break;
                CASE_TEST(fchdir_stdin);      EXPECT_SYSER(1, fchdir(STDIN_FILENO), -1, ENOTDIR); break;
                CASE_TEST(fchdir_badfd);      EXPECT_SYSER(1, fchdir(-1), -1, EBADF); break;
                CASE_TEST(file_stream);       EXPECT_SYSZR(1, test_file_stream()); break;