]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
hwmon: (emc2305) Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 11:07:03 +0000 (12:07 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 31 Jan 2026 15:38:32 +0000 (07:38 -0800)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251224110702.61746-4-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/emc2305.c

index ceae96c07ac45baa11229d84c75cd4473ad3adfe..8f80a39574f31376e34479c0bbd15c3e401570cf 100644 (file)
@@ -605,7 +605,6 @@ static int emc2305_probe(struct i2c_client *client)
 {
        struct i2c_adapter *adapter = client->adapter;
        struct device *dev = &client->dev;
-       struct device_node *child;
        struct emc2305_data *data;
        struct emc2305_platform_data *pdata;
        int vendor;
@@ -681,12 +680,10 @@ static int emc2305_probe(struct i2c_client *client)
                /* Parse and check for the available PWM child nodes */
                if (pwm_childs > 0) {
                        i = 0;
-                       for_each_child_of_node(dev->of_node, child) {
+                       for_each_child_of_node_scoped(dev->of_node, child) {
                                ret = emc2305_set_single_tz(dev, child, i);
-                               if (ret != 0) {
-                                       of_node_put(child);
+                               if (ret != 0)
                                        return ret;
-                               }
                                i++;
                        }
                } else {