MINOR: ssl: add a global tunable for the max SSL/TLS record size

Add new tunable "tune.ssl.maxrecord".

Over SSL/TLS, the client can decipher the data only once it has received
a full record. With large records, it means that clients might have to
download up to 16kB of data before starting to process them. Limiting the
record size can improve page load times on browsers located over high
latency or low bandwidth networks. It is suggested to find optimal values
which fit into 1 or 2 TCP segments (generally 1448 bytes over Ethernet
with TCP timestamps enabled, or 1460 when timestamps are disabled), keeping
in mind that SSL/TLS add some overhead. Typical values of 1419 and 2859
gave good results during tests. Use "strace -e trace=write" to find the
best value.

This trick was first suggested by Mike Belshe :

   http://www.belshe.com/2010/12/17/performance-and-the-tls-record-size/

Then requested again by Ilya Grigorik who provides some hints here :

   http://ofps.oreilly.com/titles/9781449344764/_transport_layer_security_tls.html#ch04_00000101

diff --git a/doc/configuration.txt b/doc/configuration.txt
index 70a5188862348463f4c5ac69fd58a3179e1351ef..398ce872fe2196b9a1bad448e3a71c69ec5bd24a 100644 (file)
--- a/doc/configuration.txt
+++ b/doc/configuration.txt
@@ -479,6 +479,8 @@ The following keywords are supported in the "global" section :
    - tune.sndbuf.client
    - tune.sndbuf.server
    - tune.ssl.cachesize
+   - tune.ssl.lifetime
+   - tune.ssl.maxrecord
    - tune.zlib.memlevel
    - tune.zlib.windowsize
 
@@ -900,6 +902,19 @@ tune.ssl.lifetime <timeout>
   lifetime. The real usefulness of this setting is to prevent sessions from
   being used for too long.
 
+tune.ssl.maxrecord <number>
+  Sets the maximum amount of bytes passed to SSL_write() at a time. Default
+  value 0 means there is no limit. Over SSL/TLS, the client can decipher the
+  data only once it has received a full record. With large records, it means
+  that clients might have to download up to 16kB of data before starting to
+  process them. Limiting the value can improve page load times on browsers
+  located over high latency or low bandwidth networks. It is suggested to find
+  optimal values which fit into 1 or 2 TCP segments (generally 1448 bytes over
+  Ethernet with TCP timestamps enabled, or 1460 when timestamps are disabled),
+  keeping in mind that SSL/TLS add some overhead. Typical values of 1419 and
+  2859 gave good results during tests. Use "strace -e trace=write" to find the
+  best value.
+
 tune.zlib.memlevel <number>
   Sets the memLevel parameter in zlib initialization for each session. It
   defines how much memory should be allocated for the intenal compression

diff --git a/include/types/global.h b/include/types/global.h
index 730cc64ac60fab76cfd462c5f831f5eaaa42db6b..41cd67fbef1da36b0a10825de04ae5213f11f703 100644 (file)
--- a/include/types/global.h
+++ b/include/types/global.h
@@ -117,6 +117,7 @@ struct global {
 #ifdef USE_OPENSSL
                int sslcachesize;  /* SSL cache size in session, defaults to 20000 */
                unsigned int ssllifetime;   /* SSL session lifetime in seconds */
+               unsigned int ssl_max_record; /* SSL max record size */
 #endif
 #ifdef USE_ZLIB
                int zlibmemlevel;    /* zlib memlevel */

diff --git a/src/cfgparse.c b/src/cfgparse.c
index 1a2fc8ab644835fd522266fcd6d11219e6272326..db2b21db459040412c2533f3b277b6dacbf4feea 100644 (file)
--- a/src/cfgparse.c
+++ b/src/cfgparse.c
@@ -596,6 +596,14 @@ int cfg_parse_global(const char *file, int linenum, char **args, int kwm)
 
                global.tune.ssllifetime = ssllifetime;
        }
+       else if (!strcmp(args[0], "tune.ssl.maxrecord")) {
+               if (*(args[1]) == 0) {
+                       Alert("parsing [%s:%d] : '%s' expects an integer argument.\n", file, linenum, args[0]);
+                       err_code |= ERR_ALERT | ERR_FATAL;
+                       goto out;
+               }
+               global.tune.ssl_max_record = atol(args[1]);
+       }
 #endif
        else if (!strcmp(args[0], "tune.bufsize")) {
                if (*(args[1]) == 0) {

diff --git a/src/ssl_sock.c b/src/ssl_sock.c
index 3aeba744a7c322a1cc5f09fe7e74b0887bf7e959..7fb5aa0182782c2234e497dc16d56e8d447167e9 100644 (file)
--- a/src/ssl_sock.c
+++ b/src/ssl_sock.c
@@ -1194,6 +1194,10 @@ static int ssl_sock_from_buf(struct connection *conn, struct buffer *buf, int fl
         */
        while (buf->o) {
                try = buf->o;
+
+               if (global.tune.ssl_max_record && try > global.tune.ssl_max_record)
+                       try = global.tune.ssl_max_record;
+
                /* outgoing data may wrap at the end */
                if (buf->data + try > buf->p)
                        try = buf->data + try - buf->p;