]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: libsmb: Cleanup - change to early continue in internal_resolve_name() for resolve...
authorJeremy Allison <jra@samba.org>
Mon, 20 Jul 2020 23:54:45 +0000 (16:54 -0700)
committerIsaac Boukris <iboukris@sn-devel-184>
Tue, 4 Aug 2020 08:51:41 +0000 (08:51 +0000)
No logic change.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
source3/libsmb/namequery.c

index f1d6de6a61a8204458eadbb6b3f6a6d2458cdbd9..c964d90fc4ba091a64d06504963081335126e4c7 100644 (file)
@@ -2677,15 +2677,16 @@ NTSTATUS internal_resolve_name(const char *name,
                        status = resolve_hosts(name, name_type,
                                               talloc_tos(), &ss_list,
                                               return_count);
-                       if (NT_STATUS_IS_OK(status)) {
-                               if (!convert_ss2service(return_iplist,
-                                                       ss_list,
-                                                       return_count)) {
-                                       status = NT_STATUS_NO_MEMORY;
-                                       goto fail;
-                               }
-                               goto done;
+                       if (!NT_STATUS_IS_OK(status)) {
+                               continue;
+                       }
+                       if (!convert_ss2service(return_iplist,
+                                               ss_list,
+                                               return_count)) {
+                               status = NT_STATUS_NO_MEMORY;
+                               goto fail;
                        }
+                       goto done;
                } else if(strequal( tok, "kdc")) {
                        /* deal with KDC_NAME_TYPE names here.
                         * This will result in a SRV record lookup */