]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: ti-sn65dsi86: remove unnecessary GPIO line direction check
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 20 Jun 2025 07:49:51 +0000 (09:49 +0200)
committerDouglas Anderson <dianders@chromium.org>
Thu, 26 Jun 2025 14:32:45 +0000 (07:32 -0700)
As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input
lines"), the GPIO core makes sure values cannot be set on input lines.
Remove the unnecessary check.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20250620074951.32758-1-brgl@bgdev.pl
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index 78a50b947a08e2a4451648b527e88ff1b4b4269d..3d0b4bc5129dd48b79ac3dd9f3dfea61def34927 100644 (file)
@@ -1677,11 +1677,6 @@ static int ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,
 {
        struct ti_sn65dsi86 *pdata = gpiochip_get_data(chip);
 
-       if (!test_bit(offset, pdata->gchip_output)) {
-               dev_err(pdata->dev, "Ignoring GPIO set while input\n");
-               return -EPERM;
-       }
-
        val &= 1;
        return regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,
                                  BIT(SN_GPIO_OUTPUT_SHIFT + offset),