]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: check for model-expansion cap before baselining
authorCollin Walling <walling@linux.ibm.com>
Fri, 25 Sep 2020 00:22:35 +0000 (20:22 -0400)
committerJiri Denemark <jdenemar@redhat.com>
Tue, 24 Nov 2020 20:04:07 +0000 (21:04 +0100)
Hypervisor-cpu-baseline requires the cpu-model-expansion
capability when expanding CPU model features if the
--features flag is provided.

Signed-off-by: Collin Walling <walling@linux.ibm.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_driver.c

index 20e24e247974239cf7a476f3947cadac73699fbf..5bdc6988487134cfd83c7523160fe97956eb3b7c 100644 (file)
@@ -12526,7 +12526,8 @@ qemuConnectBaselineHypervisorCPU(virConnectPtr conn,
                                    (const char **)features, migratable)))
             goto cleanup;
     } else if (ARCH_IS_S390(arch) &&
-               virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_BASELINE)) {
+               virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_BASELINE) &&
+               virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION)) {
         bool expand_features = (flags & VIR_CONNECT_BASELINE_CPU_EXPAND_FEATURES);
 
         if (!(cpu = qemuConnectCPUModelBaseline(qemuCaps, cfg->libDir,