Handle unchecked returns in src/protocols/dhcpv4/encode.c (CIDs below) (#4874)

CID 1503896: change fr_dbuff_in() to FR_DBUFF_IN_RETURN()
CID 1504021: annnotate; a preceding FR_DBUFF_REMAINING_RETURN() assures
             that there's enough space for the PEN and data-len1.

diff --git a/src/protocols/dhcpv4/encode.c b/src/protocols/dhcpv4/encode.c
index c5518512082580d82c8839e63a1bb8bb55bcd051..9c7f2fc38c1ee553779a6bdb9536ca932b04e96f 100644 (file)
--- a/src/protocols/dhcpv4/encode.c
+++ b/src/protocols/dhcpv4/encode.c
@@ -121,7 +121,7 @@ static ssize_t encode_value(fr_dbuff_t *dbuff,
                        FR_DBUFF_IN_MEMCPY_RETURN(&work_dbuff,
                                                  (uint8_t const *)&vp->vp_ipv4addr,
                                                  sizeof(vp->vp_ipv4addr));
-                       fr_dbuff_in(&work_dbuff, mask);
+                       FR_DBUFF_IN_RETURN(&work_dbuff, mask);
                        break;
                }
 
@@ -637,6 +637,7 @@ static ssize_t encode_vsio_hdr(fr_dbuff_t *dbuff,
         *      And leave room for data-len1
         */
        fr_dbuff_in_bytes(&work_dbuff, (uint8_t) da->attr, 0x00);
+       /* coverity[check_return] */
        fr_dbuff_in(&work_dbuff, dv->attr);
        fr_dbuff_in_bytes(&work_dbuff, (uint8_t) 0x00);