]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
btrfs: return a literal instead of a variable in btrfs_init_dev_replace()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 5 Mar 2025 15:01:57 +0000 (18:01 +0300)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Mar 2025 19:35:49 +0000 (20:35 +0100)
This is just a small clean up, it doesn't change how the code works.
Originally this code had a goto so we needed to set "ret = 0;" but now
it returns directly and so we can simplify it a bit by doing a
"return 0;" and removing the assignment.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dev-replace.c

index 1a82e88ec5c196a2dd841fcf3039095c00b4f55d..53d7d85cb4bea2c42f7701754f367211831d00b7 100644 (file)
@@ -103,7 +103,6 @@ no_valid_dev_replace_entry_found:
                        "found replace target device without a valid replace item");
                        return -EUCLEAN;
                }
-               ret = 0;
                dev_replace->replace_state =
                        BTRFS_IOCTL_DEV_REPLACE_STATE_NEVER_STARTED;
                dev_replace->cont_reading_from_srcdev_mode =
@@ -120,7 +119,7 @@ no_valid_dev_replace_entry_found:
                dev_replace->tgtdev = NULL;
                dev_replace->is_valid = 0;
                dev_replace->item_needs_writeback = 0;
-               return ret;
+               return 0;
        }
        slot = path->slots[0];
        eb = path->nodes[0];