]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: target: Do not write NUL characters into ASCII configfs output
authorBart Van Assche <bvanassche@acm.org>
Mon, 27 Oct 2025 18:46:38 +0000 (11:46 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 3 Nov 2025 02:47:29 +0000 (21:47 -0500)
NUL characters are not allowed in ASCII configfs output. Hence this
patch.

Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251027184639.3501254-2-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_configfs.c

index 5470c1258445a8c7ba5bc02cf76ce99be6bd0234..7e63bc71b3555709e1385bf9a5b5c7233988daee 100644 (file)
@@ -2787,7 +2787,6 @@ static ssize_t target_lu_gp_members_show(struct config_item *item, char *page)
                cur_len = snprintf(buf, LU_GROUP_NAME_BUF, "%s/%s\n",
                        config_item_name(&hba->hba_group.cg_item),
                        config_item_name(&dev->dev_group.cg_item));
-               cur_len++; /* Extra byte for NULL terminator */
 
                if ((cur_len + len) > PAGE_SIZE || cur_len > LU_GROUP_NAME_BUF) {
                        pr_warn("Ran out of lu_gp_show_attr"