]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
dnp3: fix probing test not using final null in string
authorPhilippe Antoine <contact@catenacyber.fr>
Tue, 6 Oct 2020 11:46:47 +0000 (13:46 +0200)
committerVictor Julien <victor@inliniac.net>
Wed, 7 Oct 2020 16:41:09 +0000 (18:41 +0200)
src/app-layer-dnp3.c

index 0145214b2891f8f86133f936721cf5a34c1b0139..f5b42cc1afd69aad6d81408ce4913282cdb3c1f8 100644 (file)
@@ -2102,7 +2102,7 @@ static int DNP3ProbingParserTest(void)
 
     /* Send a banner. */
     char mybanner[] = "Welcome to DNP3 SCADA.";
-    FAIL_IF(DNP3ProbingParser(NULL, STREAM_TOSERVER, (uint8_t *)mybanner, sizeof(mybanner), &rdir) != ALPROTO_DNP3);
+    FAIL_IF(DNP3ProbingParser(NULL, STREAM_TOSERVER, (uint8_t *)mybanner, sizeof(mybanner) - 1, &rdir) != ALPROTO_DNP3);
 
     PASS;
 }