]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
HID: xiaomi: constify fixed up report descriptor
authorThomas Weißschuh <linux@weissschuh.net>
Wed, 28 Aug 2024 07:33:25 +0000 (09:33 +0200)
committerBenjamin Tissoires <bentiss@kernel.org>
Thu, 5 Sep 2024 14:20:57 +0000 (16:20 +0200)
Now that the HID core can handle const report descriptors,
constify them where possible.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://patch.msgid.link/20240828-hid-const-fixup-2-v1-6-663b9210eb69@weissschuh.net
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/hid-xiaomi.c

index 035733fce2e1f30edb2fb414051bf355f8d7772d..ef6598550a40f2a6d42b563f2388605324d9a6ca 100644 (file)
@@ -14,7 +14,7 @@
 /* Fixed Mi Silent Mouse report descriptor */
 /* Button's Usage Maximum changed from 3 to 5 to make side buttons work */
 #define MI_SILENT_MOUSE_ORIG_RDESC_LENGTH   87
-static __u8 mi_silent_mouse_rdesc_fixed[] = {
+static const __u8 mi_silent_mouse_rdesc_fixed[] = {
        0x05, 0x01,         /*  Usage Page (Desktop),               */
        0x09, 0x02,         /*  Usage (Mouse),                      */
        0xA1, 0x01,         /*  Collection (Application),           */
@@ -68,8 +68,8 @@ static const __u8 *xiaomi_report_fixup(struct hid_device *hdev, __u8 *rdesc,
        case USB_DEVICE_ID_MI_SILENT_MOUSE:
                if (*rsize == MI_SILENT_MOUSE_ORIG_RDESC_LENGTH) {
                        hid_info(hdev, "fixing up Mi Silent Mouse report descriptor\n");
-                       rdesc = mi_silent_mouse_rdesc_fixed;
                        *rsize = sizeof(mi_silent_mouse_rdesc_fixed);
+                       return mi_silent_mouse_rdesc_fixed;
                }
                break;
        }