]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: snapshot: go through cleanup on error
authorJán Tomko <jtomko@redhat.com>
Mon, 27 Jan 2020 15:42:47 +0000 (16:42 +0100)
committerJán Tomko <jtomko@redhat.com>
Mon, 27 Jan 2020 16:36:05 +0000 (17:36 +0100)
A recent commit added an error check for too-nested backing chains
followed by a return, even though errors above jump to cleanup.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Fixes: b168fa88b85dec181882816ab65a59a6c4500667
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_driver.c

index fc080b4a484fc8de608c5bd99348ad85a8b10721..048855b533ccb75a8084b88ac39a3f1d0e7f312a 100644 (file)
@@ -14654,7 +14654,7 @@ qemuDomainSnapshotCreateInactiveExternal(virQEMUDriverPtr driver,
             snapdisk->src->format = VIR_STORAGE_FILE_QCOW2;
 
         if (qemuDomainStorageSourceValidateDepth(defdisk->src, 1, defdisk->dst) < 0)
-            return -1;
+            goto cleanup;
 
         /* creates cmd line args: qemu-img create -f qcow2 -o */
         if (!(cmd = virCommandNewArgList(qemuImgPath,