Pull request #4187: detection: copy ip var name in dup_rtn

Merge in SNORT/snort3 from ~ADMAMOLE/snort3:var_bug to master

Squashed commit of the following:

commit c3b9334700647d5bbd1698da377117f64e50228d
Author: Adrian Mamolea <admamole@cisco.com>
Date:   Tue Jan 30 09:22:38 2024 -0500

    detection: copy ip var name in dup_rtn

diff --git a/src/detection/rules.cc b/src/detection/rules.cc
index af7772d9d40bf7b0be618a780721b84ef394d3b4..f64bebb276506a30f7eb2531f832d155b9526775 100644 (file)
--- a/src/detection/rules.cc
+++ b/src/detection/rules.cc
@@ -123,9 +123,15 @@ RuleTreeNode* RuleStateMap::dup_rtn(RuleTreeNode* rtn, IpsPolicy* policy)
     ret->sip = sip
         ? sfvar_create_alias(sip, sip->name)
         : sfvar_deep_copy(rtn->sip);
+    if (!sip and rtn->sip->name)
+        ret->sip->name = snort_strdup(rtn->sip->name);
+
     ret->dip = dip
         ? sfvar_create_alias(dip, dip->name)
         : sfvar_deep_copy(rtn->dip);
+    if (!dip and rtn->dip->name)
+        ret->dip->name = snort_strdup(rtn->dip->name);
+
     ret->src_portobject = spo ? spo : ret->src_portobject;
     ret->dst_portobject = dpo ? dpo : ret->dst_portobject;
     ret->otnRefCount = 0;