]> git.ipfire.org Git - thirdparty/strongswan.git/commitdiff
x509: Fix build with DEBUG_LEVEL < 2 for structures that ignore unknown critical...
authorTobias Brunner <tobias@strongswan.org>
Tue, 18 Apr 2023 14:42:30 +0000 (16:42 +0200)
committerTobias Brunner <tobias@strongswan.org>
Mon, 8 May 2023 12:07:18 +0000 (14:07 +0200)
src/libstrongswan/plugins/x509/x509_ac.c
src/libstrongswan/plugins/x509/x509_ocsp_response.c
src/libstrongswan/plugins/x509/x509_pkcs10.c

index c4acce4feefdcf9eb5633028fa06903fb50291cc..2e370f5a713d1bd0b389c81e6b428ed3a295c971 100644 (file)
@@ -429,7 +429,6 @@ static bool parse_certificate(private_x509_ac_t *this)
        int extn_oid = OID_UNKNOWN;
        signature_params_t sig_alg = {};
        bool success = FALSE;
-       bool critical;
 
        parser = asn1_parser_create(acObjects, this->encoding);
 
@@ -529,8 +528,8 @@ static bool parse_certificate(private_x509_ac_t *this)
                                extn_oid = asn1_known_oid(object);
                                break;
                        case AC_OBJ_CRITICAL:
-                               critical = object.len && *object.ptr;
-                               DBG2(DBG_ASN, "  %s",(critical)?"TRUE":"FALSE");
+                               DBG2(DBG_ASN, "  %s",
+                                        object.len && *object.ptr ? "TRUE" : "FALSE");
                                break;
                        case AC_OBJ_EXTN_VALUE:
                        {
index 93fbc817388c0c86dfda709ee1ef528a947767e9..9954e55ce9d80ef22932ecc99130456a93e48d51 100644 (file)
@@ -528,7 +528,6 @@ static bool parse_basicOCSPResponse(private_x509_ocsp_response_t *this,
        u_int responses_level = level0;
        certificate_t *cert;
        bool success = FALSE;
-       bool critical;
 
        parser = asn1_parser_create(basicResponseObjects, blob);
        parser->set_top_level(parser, level0);
@@ -573,8 +572,8 @@ static bool parse_basicOCSPResponse(private_x509_ocsp_response_t *this,
                                extn_oid = asn1_known_oid(object);
                                break;
                        case BASIC_RESPONSE_CRITICAL:
-                               critical = object.len && *object.ptr;
-                               DBG2(DBG_ASN, "  %s", critical ? "TRUE" : "FALSE");
+                               DBG2(DBG_ASN, "  %s",
+                                        object.len && *object.ptr ? "TRUE" : "FALSE");
                                break;
                        case BASIC_RESPONSE_EXT_VALUE:
                                if (extn_oid == OID_NONCE &&
index 94a90ebf091f758d68a0cdee35fa6b9a4a676d23..dcf431ea83851639413ab26d739c37661dc19f07 100644 (file)
@@ -430,7 +430,6 @@ static bool parse_extension_request(private_x509_pkcs10_t *this, chunk_t blob, i
        int objectID;
        int extn_oid = OID_UNKNOWN;
        bool success = FALSE;
-       bool critical;
 
        parser = asn1_parser_create(extensionRequestObjects, blob);
        parser->set_top_level(parser, level0);
@@ -445,8 +444,8 @@ static bool parse_extension_request(private_x509_pkcs10_t *this, chunk_t blob, i
                                extn_oid = asn1_known_oid(object);
                                break;
                        case PKCS10_EXTN_CRITICAL:
-                               critical = object.len && *object.ptr;
-                               DBG2(DBG_ASN, "  %s", critical ? "TRUE" : "FALSE");
+                               DBG2(DBG_ASN, "  %s",
+                                        object.len && *object.ptr ? "TRUE" : "FALSE");
                                break;
                        case PKCS10_EXTN_VALUE:
                        {