]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBlockJobRewriteConfigDiskSource: Add debug statements when skipping disk update
authorPeter Krempa <pkrempa@redhat.com>
Fri, 26 Nov 2021 12:30:49 +0000 (13:30 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 1 Dec 2021 12:39:47 +0000 (13:39 +0100)
It makes it easier to see what's going on when trying to figure out why
the disk definition was not updated on a finalized blockjob.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/qemu/qemu_blockjob.c

index e57902df8ce217cab96c7d9d459d01ca1802d13b..56cb83d99933167bed94218256f38a96211708a8 100644 (file)
@@ -667,14 +667,23 @@ qemuBlockJobRewriteConfigDiskSource(virDomainObj *vm,
     g_autoptr(virStorageSource) copy = NULL;
     virStorageSource *n;
 
-    if (!vm->newDef)
+    if (!vm->newDef) {
+        VIR_DEBUG("not updating disk '%s' in persistent definition: no persistent definition",
+                  disk->dst);
         return;
+    }
 
-    if (!(persistDisk = virDomainDiskByTarget(vm->newDef, disk->dst)))
+    if (!(persistDisk = virDomainDiskByTarget(vm->newDef, disk->dst))) {
+        VIR_DEBUG("not updating disk '%s' in persistent definition: disk not present",
+                  disk->dst);
         return;
+    }
 
-    if (!virStorageSourceIsSameLocation(disk->src, persistDisk->src))
+    if (!virStorageSourceIsSameLocation(disk->src, persistDisk->src)) {
+        VIR_DEBUG("not updating disk '%s' in persistent definition: disk source doesn't match",
+                  disk->dst);
         return;
+    }
 
     if (!(copy = virStorageSourceCopy(newsrc, true)) ||
         virStorageSourceInitChainElement(copy, persistDisk->src, true) < 0) {