]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
can: esd_usb2: cancel urb on -EPIPE and -EPROTO
authorMartin Kelly <mkelly@xevo.com>
Tue, 5 Dec 2017 19:15:48 +0000 (11:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 16 Dec 2017 09:32:26 +0000 (10:32 +0100)
commit 7a31ced3de06e9878e4f9c3abe8f87d9344d8144 upstream.

In mcba_usb, we have observed that when you unplug the device, the driver will
endlessly resubmit failing URBs, which can cause CPU stalls. This issue
is fixed in mcba_usb by catching the codes seen on device disconnect
(-EPIPE and -EPROTO).

This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it
in the same way.

Signed-off-by: Martin Kelly <mkelly@xevo.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/usb/esd_usb2.c

index 30a082842620d5232cf345816d76bb097364e913..195bb59c61ab14a6ab47e51c5dda433071538a4c 100644 (file)
@@ -395,6 +395,8 @@ static void esd_usb2_read_bulk_callback(struct urb *urb)
                break;
 
        case -ENOENT:
+       case -EPIPE:
+       case -EPROTO:
        case -ESHUTDOWN:
                return;