Reset DNS_FETCHOPT_TRYSTALE_ONTIMEOUT on resume

Once we resume a query, we should clear DNS_FETCHOPT_TRYSTALE_ONTIMEOUT
from the options to prevent triggering the stale-answer-client-timeout
on subsequent fetches.

If we don't this may cause a crash when for example when prefetch is
triggered after a query restart.

diff --git a/lib/ns/query.c b/lib/ns/query.c
index d3546f9d5cca7b8918fc3fd76e2bb24ed0981df0..97c3be1dd047c1f8ca9a54fe23a452eadbca65cb 100644 (file)
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -6118,6 +6118,7 @@ fetch_callback(isc_task_t *task, isc_event_t *event) {
        if (client->view->cachedb != NULL && client->view->recursion) {
                client->query.attributes |= NS_QUERYATTR_RECURSIONOK;
        }
+       client->query.fetchoptions &= ~DNS_FETCHOPT_TRYSTALE_ONTIMEOUT;
        client->query.dboptions &= ~DNS_DBFIND_STALETIMEOUT;
        client->nodetach = false;