]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
iterate: clarify error messages about CNAME chains
authorPetr Špaček <petr.spacek@nic.cz>
Tue, 3 Dec 2019 14:09:47 +0000 (15:09 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Wed, 4 Dec 2019 13:18:45 +0000 (14:18 +0100)
lib/layer/iterate.c

index 9a78b23df26ffaf2e38bb439bda8b9a2e694a6fe..ebd3604b8d5c7de1720e094a95df6bf3d84f6a17 100644 (file)
@@ -574,13 +574,14 @@ static int unroll_cname(knot_pkt_t *pkt, struct kr_request *req, bool referral,
                        break;
                }
                if (++(query->cname_depth) > KR_CNAME_CHAIN_LIMIT) {
-                       VERBOSE_MSG("<= cname chain longer than %d\n",
-                                       (int)KR_CNAME_CHAIN_LIMIT);
+                       VERBOSE_MSG("<= error: CNAME chain exceeded max length %d\n",
+                                       /* people count objects from 0, no CNAME = 0 */
+                                       (int)KR_CNAME_CHAIN_LIMIT - 1);
                        return KR_STATE_FAIL;
                }
 
                if (knot_dname_is_equal(cname, pending_cname)) {
-                       VERBOSE_MSG("<= cname chain loop\n");
+                       VERBOSE_MSG("<= error: CNAME chain loop detected\n");
                        return KR_STATE_FAIL;
                }
                /* In strict mode, explicitly fetch each CNAME target. */