]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
network: be more verbose about the reason for a firewall reload
authorLaine Stump <laine@redhat.com>
Mon, 23 Nov 2020 14:48:29 +0000 (09:48 -0500)
committerLaine Stump <laine@redhat.com>
Tue, 24 Nov 2020 19:21:47 +0000 (14:21 -0500)
Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/network/bridge_driver.c

index 5d9b9eaa4f12c70f3b5d2bd81b21110440ae8551..fdad2191e61fd399d8239930e280ec117b21e44e 100644 (file)
@@ -653,6 +653,7 @@ firewalld_dbus_signal_callback(GDBusConnection *connection G_GNUC_UNUSED,
     if (STREQ(interfaceName, "org.fedoraproject.FirewallD1") &&
         STREQ(signalName, "Reloaded")) {
         reload = true;
+        VIR_DEBUG("Reload in bridge_driver because of 'Reloaded' signal");
     } else if (STREQ(interfaceName, "org.freedesktop.DBus") &&
                STREQ(signalName, "NameOwnerChanged")) {
         char *name = NULL;
@@ -661,14 +662,15 @@ firewalld_dbus_signal_callback(GDBusConnection *connection G_GNUC_UNUSED,
 
         g_variant_get(parameters, "(&s&s&s)", &name, &old_owner, &new_owner);
 
-        if (new_owner && *new_owner)
+        if (new_owner && *new_owner) {
+            VIR_DEBUG("Reload in bridge_driver because of 'NameOwnerChanged' signal, new owner is: '%s'",
+                      new_owner);
             reload = true;
+        }
     }
 
-    if (reload) {
-        VIR_DEBUG("Reload in bridge_driver because of firewalld.");
+    if (reload)
         networkReloadFirewallRules(driver, false, true);
-    }
 }
 #endif