]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
aarch64: PR target/115457 Implement missing __ARM_FEATURE_BF16 macro
authorKyrylo Tkachov <ktkachov@nvidia.com>
Thu, 27 Jun 2024 10:40:41 +0000 (16:10 +0530)
committerKyrylo Tkachov <ktkachov@nvidia.com>
Wed, 3 Jul 2024 10:12:37 +0000 (12:12 +0200)
The ACLE asks the user to test for __ARM_FEATURE_BF16 before using the
<arm_bf16.h> header but GCC doesn't set this up.
LLVM does, so this is an inconsistency between the compilers.

This patch enables that macro for TARGET_BF16_FP.
Bootstrapped and tested on aarch64-none-linux-gnu.

gcc/

PR target/115457
* config/aarch64/aarch64-c.cc (aarch64_update_cpp_builtins):
Define __ARM_FEATURE_BF16 for TARGET_BF16_FP.

gcc/testsuite/

PR target/115457
* gcc.target/aarch64/acle/bf16_feature.c: New test.

Signed-off-by: Kyrylo Tkachov <ktkachov@nvidia.com>
gcc/config/aarch64/aarch64-c.cc
gcc/testsuite/gcc.target/aarch64/acle/bf16_feature.c [new file with mode: 0644]

index d042e5fbd8c562df2e4538b51b960c194d2ca2c9..f5d70339e4ee61e4b7bfede4a174d020410a73b3 100644 (file)
@@ -252,6 +252,8 @@ aarch64_update_cpp_builtins (cpp_reader *pfile)
                        "__ARM_FEATURE_BF16_VECTOR_ARITHMETIC", pfile);
   aarch64_def_or_undef (TARGET_BF16_FP,
                        "__ARM_FEATURE_BF16_SCALAR_ARITHMETIC", pfile);
+  aarch64_def_or_undef (TARGET_BF16_FP,
+                       "__ARM_FEATURE_BF16", pfile);
   aarch64_def_or_undef (TARGET_LS64,
                        "__ARM_FEATURE_LS64", pfile);
   aarch64_def_or_undef (AARCH64_ISA_RCPC, "__ARM_FEATURE_RCPC", pfile);
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/bf16_feature.c b/gcc/testsuite/gcc.target/aarch64/acle/bf16_feature.c
new file mode 100644 (file)
index 0000000..96584b4
--- /dev/null
@@ -0,0 +1,10 @@
+/* { dg-do compile } */
+
+#pragma GCC target "+bf16"
+#ifndef __ARM_FEATURE_BF16
+#error "__ARM_FEATURE_BF16 is not defined but should be!"
+#endif
+
+void
+foo (void) {}
+