]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Link libvirt_util.la with gnutls
authorDaniel P. Berrange <berrange@redhat.com>
Wed, 20 Sep 2017 08:08:40 +0000 (09:08 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Wed, 20 Sep 2017 08:40:53 +0000 (09:40 +0100)
The util/vircrypto.c file uses gnutls, so we must directly link
libvirt_util.la with gnutls to avoid errors on OS which do not
resolve symbols against indirectly linked libraries.

This fixes a build failure on Ubuntu Trusty

  CCLD     storagevolxml2argvtest
/usr/bin/ld: ../src/.libs/libvirt_util.a(libvirt_util_la-vircrypto.o): undefined reference to symbol 'gnutls_strerror@@GNUTLS_1_4'

//usr/lib/x86_64-linux-gnu/libgnutls.so.26: error adding symbols: DSO missing from command line

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
src/Makefile.am

index c3c7a8f04d36c8c20b3ad70b77f10cb83628a0bd..173fba1e61d00de15b1a219245de7bce90f65bb8 100644 (file)
@@ -1224,7 +1224,7 @@ libvirt_util_la_LIBADD = $(CAPNG_LIBS) $(YAJL_LIBS) $(LIBNL_LIBS) \
                $(THREAD_LIBS) $(AUDIT_LIBS) $(DEVMAPPER_LIBS) \
                $(LIB_CLOCK_GETTIME) $(DBUS_LIBS) $(WIN32_EXTRA_LIBS) $(LIBXML_LIBS) \
                $(SECDRIVER_LIBS) $(NUMACTL_LIBS) $(ACL_LIBS) \
-               $(POLKIT_LIBS)
+               $(POLKIT_LIBS) $(GNUTLS_LIBS)
 
 
 noinst_LTLIBRARIES += libvirt_conf.la