]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ACPI: APEI: EINJ: Fix less than zero comparison on a size_t variable
authorColin Ian King <colin.i.king@gmail.com>
Tue, 24 Jun 2025 20:10:32 +0000 (21:10 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 26 Jun 2025 18:49:37 +0000 (20:49 +0200)
The check for c < 0 is always false because variable c is a size_t which
is not a signed type. Fix this by making c a ssize_t.

Fixes: 90711f7bdf76 ("ACPI: APEI: EINJ: Create debugfs files to enter device id and syndrome")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/20250624201032.522168-1-colin.i.king@gmail.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/einj-core.c

index f5cfa6310f0e1ced2de8710d828c1eede6619504..59777a292ffcbe01e57cbb853c64591b886f149d 100644 (file)
@@ -913,7 +913,7 @@ static ssize_t u128_write(struct file *f, const char __user *buf, size_t count,
        u8 tmp[COMPONENT_LEN];
        char byte[3] = {};
        char *s, *e;
-       size_t c;
+       ssize_t c;
        long val;
        int i;