]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
amd-xgbe: avoid misleading per-packet error log
authorRaju Rangoju <Raju.Rangoju@amd.com>
Wed, 14 Jan 2026 16:30:37 +0000 (22:00 +0530)
committerJakub Kicinski <kuba@kernel.org>
Sat, 17 Jan 2026 23:42:48 +0000 (15:42 -0800)
On the receive path, packet can be damaged because of buffer
overflow in Rx FIFO. Avoid misleading per-packet error log when
packet->errors is set, this can flood the log. Instead, rely on the
standard rtnl_link_stats64 stats.

Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver")
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Link: https://patch.msgid.link/20260114163037.2062606-1-Raju.Rangoju@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/xgbe/xgbe-drv.c

index 3ddd896d6987741254ad924ef0febc391c5bae5c..b5a60a0488967d3d73128446387910f43064f721 100644 (file)
@@ -1837,7 +1837,7 @@ static void xgbe_get_stats64(struct net_device *netdev,
        s->multicast = pstats->rxmulticastframes_g;
        s->rx_length_errors = pstats->rxlengtherror;
        s->rx_crc_errors = pstats->rxcrcerror;
-       s->rx_fifo_errors = pstats->rxfifooverflow;
+       s->rx_over_errors = pstats->rxfifooverflow;
 
        s->tx_packets = pstats->txframecount_gb;
        s->tx_bytes = pstats->txoctetcount_gb;
@@ -2292,9 +2292,6 @@ read_again:
                        goto read_again;
 
                if (error || packet->errors) {
-                       if (packet->errors)
-                               netif_err(pdata, rx_err, netdev,
-                                         "error in received packet\n");
                        dev_kfree_skb(skb);
                        goto next_packet;
                }