[2372] handle comments in the start state

diff --git a/src/lib/dns/master_lexer.cc b/src/lib/dns/master_lexer.cc
index 89982fbc4e2920741e86b209c5ee18c552e604bb..b446415fe233e0ff113b9d47c46406adf4ccaa58 100644 (file)
--- a/src/lib/dns/master_lexer.cc
+++ b/src/lib/dns/master_lexer.cc
@@ -38,6 +38,18 @@ struct MasterLexer::MasterLexerImpl {
                         token_(Token::NOT_STARTED)
     {}
 
+    int skipComment(int c) {
+        if (c == ';') {
+            while (true) {
+                c = source_->getChar();
+                if (c == '\n' || c == InputSource::END_OF_STREAM) {
+                    return (c);
+                }
+            }
+        }
+        return (c);
+    }
+
     std::vector<InputSourcePtr> sources_;
     InputSource* source_;       // current source
     size_t paren_count_;
@@ -185,13 +197,12 @@ State::getInstance(ID state_id) {
         return (START_STATE);
     case CRLF:
         return (CRLF_STATE);
-    case EatLine:
-        return (CRLF_STATE);    // XXX
     case String:
-        return (STRING_STATE);    // XXX
+        return (STRING_STATE);
     }
 }
 
+namespace {
 inline void
 cancelOptions(MasterLexer::Options& options,
               MasterLexer::Options canceled_options)
@@ -199,13 +210,15 @@ cancelOptions(MasterLexer::Options& options,
     options = static_cast<MasterLexer::Options>(
         options & static_cast<MasterLexer::Options>(~canceled_options));
 }
+}
 
 const State*
 Start::handle(MasterLexer& lexer, MasterLexer::Options& options) const {
     size_t& paren_count = getLexerImpl(lexer)->paren_count_;
 
     while (true) {
-        const int c = getLexerImpl(lexer)->source_->getChar();
+        const int c = getLexerImpl(lexer)->skipComment(
+            getLexerImpl(lexer)->source_->getChar());
         if (c == InputSource::END_OF_STREAM) {
             if (paren_count != 0) {
                 getLexerImpl(lexer)->token_ = Token(Token::UNBALANCED_PAREN);
@@ -241,8 +254,7 @@ Start::handle(MasterLexer& lexer, MasterLexer::Options& options) const {
                 getLexerImpl(lexer)->token_ = Token(Token::UNBALANCED_PAREN);
                 return (NULL);
             }
-            --paren_count;
-            if (paren_count == 0) {
+            if (--paren_count == 0) {
                 options = getLexerImpl(lexer)->orig_options_;
             }
             continue;

diff --git a/src/lib/dns/master_lexer_state.h b/src/lib/dns/master_lexer_state.h
index 4fdc91f303152c9a455f3e4c4a3e355e91914915..a91577851a62ffd75c42afd8940aaa4b07a7f16a 100644 (file)
--- a/src/lib/dns/master_lexer_state.h
+++ b/src/lib/dns/master_lexer_state.h
@@ -37,7 +37,6 @@ public:
     enum ID {
         Start,                  ///< TBD
         CRLF,
-        EatLine,
         String
     };
     static const State& getInstance(ID state_id);

diff --git a/src/lib/dns/tests/master_lexer_state_unittest.cc b/src/lib/dns/tests/master_lexer_state_unittest.cc
index 0f8da0d31b33ccafe73f10254ec860852faab69d..ea79dd1e3be7a93bde42520f0bbe1848df15cf8e 100644 (file)
--- a/src/lib/dns/tests/master_lexer_state_unittest.cc
+++ b/src/lib/dns/tests/master_lexer_state_unittest.cc
@@ -47,6 +47,7 @@ protected:
     const State* const s_null;
     const State& s_start;
     const State& s_crlf;
+
     const State& s_string;
     std::stringstream ss;
     MasterLexer::Options options, orig_options;
@@ -178,14 +179,28 @@ TEST_F(MasterLexerStateTest, unbalancedParentheses) {
     EXPECT_EQ(Token::UNBALANCED_PAREN, s_start.getToken(lexer).getErrorCode());
     EXPECT_FALSE(s_start.wasLastEOL(lexer));
 
-    // Reach EOF without a dangling open parenthesis.
+    // Reach EOF with a dangling open parenthesis.
     ss << "(a";
     EXPECT_EQ(&s_string, s_start.handle(lexer, options)); // consume '(a'
     EXPECT_EQ(1, s_start.getParenCount(lexer));
     EXPECT_EQ(s_null, s_start.handle(lexer, options));    // reach EOF
     ASSERT_EQ(Token::ERROR, s_start.getToken(lexer).getType());
     EXPECT_EQ(Token::UNBALANCED_PAREN, s_start.getToken(lexer).getErrorCode());
-    EXPECT_EQ(0, s_start.getParenCount(lexer));
+    EXPECT_EQ(0, s_start.getParenCount(lexer)); // should be reset to 0
+}
+
+TEST_F(MasterLexerStateTest, startToComment) {
+    // Begin with 'start', skip space, then encounter a comment.  Skip
+    // the rest of the line, and recognize the new line.  Note that the
+    // second ';' is simply ignored.
+    ss << "  ;a;\n";
+    EXPECT_EQ(s_null, s_start.handle(lexer, options));
+    EXPECT_EQ(Token::END_OF_LINE, s_start.getToken(lexer).getType());
+
+    // Likewise, but the comment ends with EOF.
+    ss << "  ;a;";
+    EXPECT_EQ(s_null, s_start.handle(lexer, options));
+    EXPECT_EQ(Token::END_OF_FILE, s_start.getToken(lexer).getType());
 }
 
 }