]> git.ipfire.org Git - thirdparty/coreutils.git/commitdiff
maint: be less strict about executable permissions of tests
authorBernhard Voelker <mail@bernhard-voelker.de>
Wed, 4 Mar 2015 22:25:57 +0000 (23:25 +0100)
committerBernhard Voelker <mail@bernhard-voelker.de>
Thu, 5 Mar 2015 15:54:52 +0000 (16:54 +0100)
With "umask 0027" or even "umask 0077", the git clone of coreutils
does not have the executable bit set for 'other' (or 'group).
Therefore, "make syntax-check" would fail.

* cfg.mk (sc_tests_executable): Change the -perm argument of find(1)
to only print the names of the files which are not executable by the
user, rather than insisting on ugo+x (octal 111).

cfg.mk

diff --git a/cfg.mk b/cfg.mk
index ab0b8a4b6294290e9cd1c5379563bc442cf7b925..d65af2726e6034a774893163ffcd38bea250bec6 100644 (file)
--- a/cfg.mk
+++ b/cfg.mk
@@ -118,7 +118,7 @@ sc_tests_list_consistency:
 sc_tests_executable:
        @test_extensions_rx=`echo $(TEST_EXTENSIONS)                    \
          | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
-       find tests/ \( $$test_extensions_rx \) \! -perm -111 -print \
+       find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
          | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
            && exit 1; :