]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: renesas: r8a77990: Re-add voltages to OPP table
authorGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 8 Oct 2024 09:14:21 +0000 (11:14 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 21 Feb 2025 15:22:59 +0000 (16:22 +0100)
When CONFIG_ENERGY_MODEL=y:

    cpu cpu0: EM: invalid perf. state: -22

When removing the (incorrect) voltages from the Operating Points
Parameters tables, it was assumed they were optional, and unused, when
none of the CPU nodes is tied to a regulator using the "cpu-supply"
property.  This assumption turned out to be incorrect, causing the
reported error message.

Fix this by re-adding the (correct) voltages.  Note that because all
voltages are identical, all operating points are considered to have the
same efficiency, and the energy model always picks the one with the
highest clock rate.

Reported-by: Renesas Test Team via Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fixes: fb76b0fae3ca8803 ("arm64: dts: renesas: r8a77990: Remove bogus voltages from OPP table")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/80890bc244670bc3e8d6fc89fb2c3cb23e7025f5.1728377971.git.geert+renesas@glider.be
arch/arm64/boot/dts/renesas/r8a77990.dtsi

index 233af3081e84a407d35226c692e1e41bc3a815b4..50fbf7251665a49154b4a2a3ff0a9133ec87a3b7 100644 (file)
        cluster1_opp: opp-table-1 {
                compatible = "operating-points-v2";
                opp-shared;
+
                opp-800000000 {
                        opp-hz = /bits/ 64 <800000000>;
+                       opp-microvolt = <1030000>;
                        clock-latency-ns = <300000>;
                };
                opp-1000000000 {
                        opp-hz = /bits/ 64 <1000000000>;
+                       opp-microvolt = <1030000>;
                        clock-latency-ns = <300000>;
                };
                opp-1200000000 {
                        opp-hz = /bits/ 64 <1200000000>;
+                       opp-microvolt = <1030000>;
                        clock-latency-ns = <300000>;
                        opp-suspend;
                };