]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
test: Use atomic access to @nextDomID in struct virTestDriver
authorPeter Krempa <pkrempa@redhat.com>
Wed, 24 Jun 2015 13:08:47 +0000 (15:08 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 25 Jun 2015 12:09:48 +0000 (14:09 +0200)
src/test/test_driver.c

index 0cd8e6a6ad21580ab7e00e8680bdeaff31aea6f1..1d5463959a499814bfb09f70dedbb62264105862 100644 (file)
@@ -59,6 +59,7 @@
 #include "virstring.h"
 #include "cpu/cpu.h"
 #include "virauth.h"
+#include "viratomic.h"
 
 #define VIR_FROM_THIS VIR_FROM_TEST
 
@@ -95,7 +96,6 @@ typedef struct _testAuth *testAuthPtr;
 struct _testDriver {
     virMutex lock;
 
-    int nextDomID;
     virNodeInfo nodeInfo;
     virInterfaceObjList ifaces;
     bool transaction_running;
@@ -107,6 +107,9 @@ struct _testDriver {
     size_t numAuths;
     testAuthPtr auths;
 
+    /* virAtomic access only */
+    volatile int nextDomID;
+
     /* immutable pointer, immutable object after being initialized with
      * testBuildCapabilities */
     virCapsPtr caps;
@@ -417,7 +420,7 @@ testDriverNew(void)
         !(ret->networks = virNetworkObjListNew()))
         goto error;
 
-    ret->nextDomID = 1;
+    virAtomicIntSet(&ret->nextDomID, 1);
 
     return ret;
 
@@ -712,7 +715,7 @@ testDomainStartState(testDriverPtr privconn,
         goto cleanup;
 
     virDomainObjSetState(dom, VIR_DOMAIN_RUNNING, reason);
-    dom->def->id = privconn->nextDomID++;
+    dom->def->id = virAtomicIntAdd(&privconn->nextDomID, 1);
 
     if (virDomainObjSetDefTransient(privconn->caps,
                                     privconn->xmlopt,