]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/parse: improve direction setting on sigs
authorVictor Julien <victor@inliniac.net>
Tue, 31 Jul 2018 07:14:26 +0000 (09:14 +0200)
committerVictor Julien <victor@inliniac.net>
Thu, 21 Mar 2019 18:19:04 +0000 (19:19 +0100)
Only set both directions if no direction has been explicitly set before.

src/detect-parse.c

index 77608269628b99ae68a957e6eea450d8847f7ea5..cbc57576b4634d96636414a4abd0cc146dc81322 100644 (file)
@@ -1835,8 +1835,10 @@ static Signature *SigInitHelper(DetectEngineCtx *de_ctx, const char *sigstr,
     }
 
     if (!(sig->init_data->init_flags & SIG_FLAG_INIT_FLOW)) {
-        sig->flags |= SIG_FLAG_TOSERVER;
-        sig->flags |= SIG_FLAG_TOCLIENT;
+        if ((sig->flags & (SIG_FLAG_TOSERVER|SIG_FLAG_TOCLIENT)) == 0) {
+            sig->flags |= SIG_FLAG_TOSERVER;
+            sig->flags |= SIG_FLAG_TOCLIENT;
+        }
     }
 
     SCLogDebug("sig %"PRIu32" SIG_FLAG_APPLAYER: %s, SIG_FLAG_PACKET: %s",