dmaengine: idxd: fix memory leak in error handling path of idxd_setup_groups

commit aa6f4f945b10eac57aed46154ae7d6fada7fccc7 upstream.

Memory allocated for groups is not freed if an error occurs during
idxd_setup_groups(). To fix it, free the allocated memory in the reverse
order of allocation before exiting the function in case of an error.

Fixes: defe49f96012 ("dmaengine: idxd: fix group conf_dev lifetime")
Cc: stable@vger.kernel.org
Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Link: https://lore.kernel.org/r/20250404120217.48772-4-xueshuai@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
index 635838a81e0f10888451fc536a977d34321785b3..fe4a14813bba5a3e83a609c2b74bc5e384a73ebc 100644 (file)
--- a/drivers/dma/idxd/init.c
+++ b/drivers/dma/idxd/init.c
@@ -326,6 +326,7 @@ static int idxd_setup_groups(struct idxd_device *idxd)
                rc = dev_set_name(conf_dev, "group%d.%d", idxd->id, group->id);
                if (rc < 0) {
                        put_device(conf_dev);
+                       kfree(group);
                        goto err;
                }
 
@@ -350,7 +351,10 @@ static int idxd_setup_groups(struct idxd_device *idxd)
        while (--i >= 0) {
                group = idxd->groups[i];
                put_device(group_confdev(group));
+               kfree(group);
        }
+       kfree(idxd->groups);
+
        return rc;
 }