reftable/writer: improve error when passed an invalid block size

The reftable format only supports block sizes up to 16MB. When the
writer is being passed a value bigger than that it simply calls
abort(3P), which isn't all that helpful due to the lack of a proper
error message.

Improve this by calling `BUG()` instead.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/reftable/writer.c b/reftable/writer.c
index a043025b01e4421b3652f7a9c69a70bda7631f9e..45b3e9ce1f2e994625ada9efc8f461060706e6f2 100644 (file)
--- a/reftable/writer.c
+++ b/reftable/writer.c
@@ -128,10 +128,8 @@ reftable_new_writer(ssize_t (*writer_func)(void *, const void *, size_t),
        if (_opts)
                opts = *_opts;
        options_set_defaults(&opts);
-       if (opts.block_size >= (1 << 24)) {
-               /* TODO - error return? */
-               abort();
-       }
+       if (opts.block_size >= (1 << 24))
+               BUG("configured block size exceeds 16MB");
 
        strbuf_init(&wp->block_writer_data.last_key, 0);
        strbuf_init(&wp->last_key, 0);