Fix i386 asinhl (sNaN) (bug 20218).

The i386 version of asinhl returns sNaN (without raising any
exceptions) for sNaN input.  This patch fixes it to add non-finite
arguments to themselves, so that "invalid" is raised and qNaN
returned.

Tested for x86_64 and x86.

	[BZ #20218]
	* sysdeps/i386/fpu/s_asinhl.S (__asinhl): Add non-finite argument
	to itself.
	* math/libm-test.inc (asinh_test_data): Add sNaN tests.

diff --git a/ChangeLog b/ChangeLog
index 5688d2009feac1af9e5d1e8ca3b6c9965eaa3356..cba504e7b29c7d22bc67f6bedb567c1a6c4fa675 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2016-06-07  Joseph Myers  <joseph@codesourcery.com>
+
+       [BZ #20218]
+       * sysdeps/i386/fpu/s_asinhl.S (__asinhl): Add non-finite argument
+       to itself.
+       * math/libm-test.inc (asinh_test_data): Add sNaN tests.
+
 2016-06-07  H.J. Lu  <hongjiu.lu@intel.com>
 
        [BZ #20195]

diff --git a/math/libm-test.inc b/math/libm-test.inc
index f9b2c8ada8112c8fa876204ee29379ff21e6e790..fb7a71baf815ca7f63e3dbf1fc291bbccd1288ff 100644 (file)
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -1878,6 +1878,8 @@ static const struct test_f_f_data asinh_test_data[] =
     TEST_f_f (asinh, minus_infty, minus_infty, ERRNO_UNCHANGED|NO_TEST_INLINE),
     TEST_f_f (asinh, qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
     TEST_f_f (asinh, -qnan_value, qnan_value, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
+    TEST_f_f (asinh, snan_value, qnan_value, INVALID_EXCEPTION),
+    TEST_f_f (asinh, -snan_value, qnan_value, INVALID_EXCEPTION),
     AUTO_TESTS_f_f (asinh),
   };
 

diff --git a/sysdeps/i386/fpu/s_asinhl.S b/sysdeps/i386/fpu/s_asinhl.S
index c9d5714bee95506f530fc921b72ae3ac77abed47..e055386071b9e67236e16054f081f486592e1d31 100644 (file)
--- a/sysdeps/i386/fpu/s_asinhl.S
+++ b/sysdeps/i386/fpu/s_asinhl.S
@@ -88,6 +88,7 @@ ENTRY(__asinhl)
 4:     ret
 
 7:     fldt    4(%esp)
+       fadd    %st
        ret
 
 6:     faddl   MO(one)