]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
spec: firewalld is always enabled
authorAndrea Bolognani <abologna@redhat.com>
Mon, 5 Oct 2020 16:31:37 +0000 (18:31 +0200)
committerAndrea Bolognani <abologna@redhat.com>
Fri, 9 Oct 2020 12:34:18 +0000 (14:34 +0200)
Knowing this, we can remove some code.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
libvirt.spec.in

index 618b289bc99364989849b40dad786671f9f9942b..949b91149199d0a3971bd177b3b17ac4a706a54d 100644 (file)
@@ -88,7 +88,6 @@
 %define with_fuse             0
 %define with_sanlock          0
 %define with_numad            0
-%define with_firewalld        0
 %define with_firewalld_zone   0
 %define with_libssh2          0
 %define with_wireshark        0
     %endif
 %endif
 
-%define with_firewalld 1
-
 %if 0%{?fedora} || 0%{?rhel} > 7
     %define with_firewalld_zone 0%{!?_without_firewalld_zone:1}
 %endif
@@ -1089,12 +1086,6 @@ exit 1
     %define arg_sanlock -Dsanlock=disabled
 %endif
 
-%if %{with_firewalld}
-    %define arg_firewalld -Dfirewalld=enabled
-%else
-    %define arg_firewalld -Dfirewalld=disabled
-%endif
-
 %if %{with_firewalld_zone}
     %define arg_firewalld_zone -Dfirewalld_zone=enabled
 %else
@@ -1171,7 +1162,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/%{name}.spec)
            -Dlibnl=enabled \
            -Daudit=enabled \
            -Ddtrace=enabled \
-           %{?arg_firewalld} \
+           -Dfirewalld=enabled \
            %{?arg_firewalld_zone} \
            %{?arg_wireshark} \
            -Dpm_utils=disabled \