]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kfifo: fix kmalloc_array_node() argument order
authorRandy Dunlap <rdunlap@infradead.org>
Sat, 20 Dec 2025 05:45:41 +0000 (21:45 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 27 Jan 2026 03:07:09 +0000 (19:07 -0800)
To be consistent, pass the kmalloc_array_node() parameters in the order
(number_of_elements, element_size).  Since only the product of the two
values is used, this is not a bug fix.

Link: https://lkml.kernel.org/r/20251220054541.2295599-1-rdunlap@infradead.org
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=216015
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Stefani Seibold <stefani@seibold.net>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/kfifo.c

index 525e66f8294c8c22c6b3e26c34522f6ce607479b..2633f9cc336ccdda5ceb5e3a7b3fcd69d7b92675 100644 (file)
@@ -41,7 +41,7 @@ int __kfifo_alloc_node(struct __kfifo *fifo, unsigned int size,
                return -EINVAL;
        }
 
-       fifo->data = kmalloc_array_node(esize, size, gfp_mask, node);
+       fifo->data = kmalloc_array_node(size, esize, gfp_mask, node);
 
        if (!fifo->data) {
                fifo->mask = 0;