codesearch: deduplicate $git->{nick} field

While PublicInbox::Config is responsible for some instances of
setting $git->{nick}, more PublicInbox::Git objects may be
created from loading the cindex and we should do our best to
reuse that memory, too.

Followup-to: 84ed7ec1c887 (dedupe inbox names, coderepo nicks + git dirs, 2024-03-04)

diff --git a/lib/PublicInbox/CodeSearch.pm b/lib/PublicInbox/CodeSearch.pm
index 48033bb5489f9acb5d61ed0ae548d981c2b37790..e5fa4480afae336be269d9bc789e6573daa176ec 100644 (file)
--- a/lib/PublicInbox/CodeSearch.pm
+++ b/lib/PublicInbox/CodeSearch.pm
@@ -283,7 +283,8 @@ EOM
                $nick =~ s!$lre!$nick_pfx!s or next;
                $dir2cr{$p} = $coderepos->{$nick} //= do {
                        my $git = PublicInbox::Git->new($p);
-                       $git->{nick} = $nick; # for git->pub_urls
+                       my %dedupe = ($nick => undef);
+                       ($git->{nick}) = keys %dedupe; # for git->pub_urls
                        $git;
                };
        }