]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: chemical: scd4x: fix reported channel endianness
authorFiona Klute <fiona.klute@gmx.de>
Sat, 13 Dec 2025 16:32:26 +0000 (17:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 30 Jan 2026 09:27:38 +0000 (10:27 +0100)
commit 81d5a5366d3c20203fb9d7345e1aa46d668445a2 upstream.

The driver converts values read from the sensor from BE to CPU
endianness in scd4x_read_meas(). The result is then pushed into the
buffer in scd4x_trigger_handler(), so on LE architectures parsing the
buffer using the reported BE type gave wrong results.

scd4x_read_raw() which provides sysfs *_raw values is not affected, it
used the values returned by scd4x_read_meas() without further
conversion.

Fixes: 49d22b695cbb6 ("drivers: iio: chemical: Add support for Sensirion SCD4x CO2 sensor")
Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/chemical/scd4x.c

index ca6b20270711a6875d1a663f30c6cb2f8769ff08..6fd0fa3d3fbe168edbaeca702d709a1aedaa68cc 100644 (file)
@@ -585,7 +585,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
        {
@@ -600,7 +600,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
        {
@@ -613,7 +613,7 @@ static const struct iio_chan_spec scd4x_channels[] = {
                        .sign = 'u',
                        .realbits = 16,
                        .storagebits = 16,
-                       .endianness = IIO_BE,
+                       .endianness = IIO_CPU,
                },
        },
 };