]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iommu/apple-dart: fix device leak on of_xlate()
authorJohan Hovold <johan@kernel.org>
Mon, 20 Oct 2025 04:53:05 +0000 (06:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:39 +0000 (10:14 +0100)
commit a6eaa872c52a181ae9a290fd4e40c9df91166d7a upstream.

Make sure to drop the reference taken to the iommu platform device when
looking up its driver data during of_xlate().

Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver")
Cc: stable@vger.kernel.org # 5.15
Cc: Sven Peter <sven@kernel.org>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/apple-dart.c

index e8d7bcbee1a22b086312f4aea2dc20aa1ac7b0a3..05fad2c50c5a912f5c6c7b963cd7cdf0dfed59ac 100644 (file)
@@ -790,6 +790,8 @@ static int apple_dart_of_xlate(struct device *dev,
        struct apple_dart *cfg_dart;
        int i, sid;
 
+       put_device(&iommu_pdev->dev);
+
        if (args->args_count != 1)
                return -EINVAL;
        sid = args->args[0];