]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
Adjust test on PGconn.tty for libpq 14
authorDenis Laxalde <denis.laxalde@dalibo.com>
Wed, 29 Sep 2021 08:36:23 +0000 (10:36 +0200)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Wed, 29 Sep 2021 13:48:30 +0000 (14:48 +0100)
Quoting https://www.postgresql.org/docs/14/libpq-status.html:

  [PQtty] no longer does anything, but it remains for backwards
  compatibility. The function always return an empty string.

Or perhaps we should drop 'tty' property (and binding), since this is at
least obsolete since PostgreSQL 7.4?

tests/pq/test_pgconn.py

index cb00e10d14a236ae2885ca2f11aa3e4f2798213b..89df2953e80b45a2d3481c28c3c5dd3b1aa0c268 100644 (file)
@@ -224,6 +224,7 @@ def test_port(pgconn):
         pgconn.port
 
 
+@pytest.mark.libpq("< 14")
 def test_tty(pgconn):
     tty = [o.val for o in pgconn.info if o.keyword == b"tty"][0]
     assert pgconn.tty == tty
@@ -232,6 +233,12 @@ def test_tty(pgconn):
         pgconn.tty
 
 
+@pytest.mark.libpq(">= 14")
+def test_tty_noop(pgconn):
+    assert not any(o.val for o in pgconn.info if o.keyword == b"tty")
+    assert pgconn.tty == b""
+
+
 def test_transaction_status(pgconn):
     assert pgconn.transaction_status == pq.TransactionStatus.IDLE
     pgconn.exec_(b"begin")