]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: usb: sr9700: use ETH_ALEN instead of magic number
authorEthan Nelson-Moore <enelsonmoore@gmail.com>
Fri, 23 Jan 2026 07:06:39 +0000 (23:06 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 25 Jan 2026 23:01:04 +0000 (15:01 -0800)
The driver hardcodes the number 6 as the number of bytes to write to
the SR_PAR register, which stores the MAC address. Use ETH_ALEN instead
to make the code clearer.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Link: https://patch.msgid.link/20260123070645.56434-1-enelsonmoore@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/sr9700.c

index 9c7cd0db1768c61597fad2d6ab6ae4933af0285f..446857de8e15c074fe8ce4394a197bcbeacdd56b 100644 (file)
@@ -271,7 +271,7 @@ static int sr9700_set_mac_address(struct net_device *netdev, void *p)
        }
 
        eth_hw_addr_set(netdev, addr->sa_data);
-       sr_write_async(dev, SR_PAR, 6, netdev->dev_addr);
+       sr_write_async(dev, SR_PAR, ETH_ALEN, netdev->dev_addr);
 
        return 0;
 }