]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: gyro: fxas21002c: Fix missing data update in trigger handler
authorCarlos Song <carlos.song@nxp.com>
Sat, 16 Nov 2024 15:29:45 +0000 (10:29 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jan 2025 16:15:55 +0000 (17:15 +0100)
commit fa13ac6cdf9b6c358e7d77c29fb60145c7a87965 upstream.

The fxas21002c_trigger_handler() may fail to acquire sample data because
the runtime PM enters the autosuspend state and sensor can not return
sample data in standby mode..

Resume the sensor before reading the sample data into the buffer within the
trigger handler. After the data is read, place the sensor back into the
autosuspend state.

Fixes: a0701b6263ae ("iio: gyro: add core driver for fxas21002c")
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20241116152945.4006374-1-Frank.Li@nxp.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/gyro/fxas21002c_core.c

index 410e5e9f2672e19584ab8a181a63f27d977ec05f..f331f7480805b2593f4a8e19d62ca6cd3a1f5701 100644 (file)
@@ -730,14 +730,21 @@ static irqreturn_t fxas21002c_trigger_handler(int irq, void *p)
        int ret;
 
        mutex_lock(&data->lock);
+       ret = fxas21002c_pm_get(data);
+       if (ret < 0)
+               goto out_unlock;
+
        ret = regmap_bulk_read(data->regmap, FXAS21002C_REG_OUT_X_MSB,
                               data->buffer, CHANNEL_SCAN_MAX * sizeof(s16));
        if (ret < 0)
-               goto out_unlock;
+               goto out_pm_put;
 
        iio_push_to_buffers_with_timestamp(indio_dev, data->buffer,
                                           data->timestamp);
 
+out_pm_put:
+       fxas21002c_pm_put(data);
+
 out_unlock:
        mutex_unlock(&data->lock);