]> git.ipfire.org Git - thirdparty/ulogd2.git/commitdiff
filter: HWHDR: remove zero-initialization of MAC type
authorJeremy Sowden <jeremy@azazel.net>
Tue, 30 Nov 2021 10:55:33 +0000 (10:55 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 30 Nov 2021 19:55:17 +0000 (20:55 +0100)
We don't need to initialize `type`, and even if we did the right value
would be `ARPHDR_VOID`, not `0`, which is a valid MAC type
(`ARPHDR_NETROM`).

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
filter/ulogd_filter_HWHDR.c

index 015121511b08dbd24dd99726ec5fae92543295f7..bbca5e9b92f28c03dfc7d01bef2f9d7344802a6b 100644 (file)
@@ -171,7 +171,7 @@ static int interp_mac2str(struct ulogd_pluginstance *pi)
 {
        struct ulogd_key *ret = pi->output.keys;
        struct ulogd_key *inp = pi->input.keys;
-       uint16_t type = 0;
+       uint16_t type;
 
        if (pp_is_valid(inp, KEY_OOB_PROTOCOL))
                okey_set_u16(&ret[KEY_MAC_PROTOCOL],