]> git.ipfire.org Git - thirdparty/e2fsprogs.git/commitdiff
zap_sector: fix memory leak
authorwuguanghao <wuguanghao3@huawei.com>
Wed, 30 Jun 2021 08:27:15 +0000 (16:27 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 16 Jul 2021 03:20:39 +0000 (23:20 -0400)
In zap_sector(), need free buf before return,
otherwise it will cause memory leak.

Signed-off-by: Wu Guanghao <wuguanghao3@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: Wu Bo <wubo40@huawei.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
misc/mke2fs.c

index 54aa340a45815697c6904e2d9fe22bd8de26a215..9fa6eaa7392193d904feb93221028efd6fb31e38 100644 (file)
@@ -585,8 +585,10 @@ static void zap_sector(ext2_filsys fs, int sect, int nsect)
                else {
                        magic = (unsigned int *) (buf + BSD_LABEL_OFFSET);
                        if ((*magic == BSD_DISKMAGIC) ||
-                           (*magic == BSD_MAGICDISK))
+                           (*magic == BSD_MAGICDISK)) {
+                               free(buf);
                                return;
+                       }
                }
        }