wifi: mac80211: remove an unneeded check in Rx

Coverity pointed out that __ieee80211_rx_h_amsdu() checks if rx->sta is
NULL before dereferencing it but not always.

Since rx->sta can't be NULL at this point, just remove the check to
avoid confusion

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250101070249.033096029d0a.I0923387246a6152f589d278f27f27bce52daee79@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 58c1b9a4e8b5d3a40933bab0f8207e0f2c9fb391..3c0cc3cf5ec806962a9a463069869718fe14c278 100644 (file)
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -3034,8 +3034,7 @@ __ieee80211_rx_h_amsdu(struct ieee80211_rx_data *rx, u8 data_offset)
                        check_da = NULL;
                        break;
                case NL80211_IFTYPE_STATION:
-                       if (!rx->sta ||
-                           !test_sta_flag(rx->sta, WLAN_STA_TDLS_PEER))
+                       if (!test_sta_flag(rx->sta, WLAN_STA_TDLS_PEER))
                                check_sa = NULL;
                        break;
                case NL80211_IFTYPE_MESH_POINT: